[PATCH] Improve testing tools #4419

New Issue

Itms · 2016-12-18T09:43:41Z

Itms commented

2016-12-18 09:43:41 +00:00

We have a lot of useful tools around, for unit tests, code coverage, documentation etc. but they are not always up-to-date or usable with Jenkins.

This ticket is for tracking some needed updates.

We have a lot of useful tools around, for unit tests, code coverage, documentation etc. but they are not always up-to-date or usable with Jenkins. This ticket is for tracking some needed updates.

Itms added the

labels 2016-12-18 09:43:41 +00:00

Itms added this to the Alpha 22 milestone 2016-12-18 09:43:41 +00:00

Itms self-assigned this 2016-12-18 09:43:41 +00:00

Itms changed title from ~~Improve testing tools~~ to [PATCH] Improve testing tools

2016-12-18 10:16:09 +00:00

Itms commented

2016-12-18 10:17:30 +00:00

Attachment fix_cache_creation.patch (1607 bytes) added

Fix the creation of binaries/data/cache by using _testcache everywhere

**Attachment** fix_cache_creation.patch (1607 bytes) added Fix the creation of binaries/data/cache by using _testcache everywhere

fix_cache_creation.patch

1.6 KiB

Itms commented

2016-12-18 10:18:20 +00:00

Attachment fix_xml_output.patch (659 bytes) added

Do not print anything outside the CxxTest functions, or that breaks the XML output that Jenkins needs

**Attachment** fix_xml_output.patch (659 bytes) added Do not print anything outside the [CxxTest](CxxTest) functions, or that breaks the XML output that Jenkins needs

fix_xml_output.patch

659 B

Itms commented

2016-12-18 11:16:20 +00:00

See 00be16a3a3

Do not print things outside of the standard TS_FAIL output, or garbage will be added to the XML output when running the tests under Jenkins.

This patch has the extra benefit that the stack trace actually appears on Windows now, instead of going into the void.

Tested by Vladislav, refs #4419

See 00be16a3a301dc0850e72a31c9769f06d1d5f7a8 ``` Do not print things outside of the standard TS_FAIL output, or garbage will be added to the XML output when running the tests under Jenkins. This patch has the extra benefit that the stack trace actually appears on Windows now, instead of going into the void. Tested by Vladislav, refs #4419 ```

elexis commented

2016-12-18 11:31:41 +00:00

(test_setup.js would have been slightly cleaner if the last 2 lines were merged). I guess the creation of the cache directory is the result of the mount path, since the oosdumps were also written to that directory in non-visual replaymode, but not in the visual mode (or something like that).

(`test_setup.js` would have been slightly cleaner if the last 2 lines were merged). I guess the creation of the cache directory is the result of the mount path, since the oosdumps were also written to that directory in non-visual replaymode, but not in the visual mode (or something like that).

Itms commented

2016-12-18 11:42:03 +00:00

Ah that's interesting. The cache patch doesn't seem to work on Windows anyways, so I'll take a closer look at all this.

Itms commented

2016-12-25 22:03:32 +00:00

See 6d4ec2b8d3

Fix the cache directory appearing during tests.

Summary: Refs #4419.

Test Plan: When running tests, make sure nothing is created.

Reviewers: leper

Reviewed By: leper

Subscribers: leper, Vulcan

Differential Revision: https://code.wildfiregames.com/D1

See 6d4ec2b8d3511b0e83d5e275be8c966e51a10c51 ``` Fix the cache directory appearing during tests. Summary: Refs #4419. Test Plan: When running tests, make sure nothing is created. Reviewers: leper Reviewed By: leper Subscribers: leper, Vulcan Differential Revision: https://code.wildfiregames.com/D1 ```

Itms commented

2016-12-25 22:08:37 +00:00

Do we have a ticket for the visual/non-visual inconsistency? If no it should get a separate one.

About the commit message: team members are invited to comment on its verbosity on the forums.

Not closing the ticket because other things are incoming.

Do we have a ticket for the visual/non-visual inconsistency? If no it should get a separate one. About the commit message: team members are invited to comment on its verbosity on the forums. Not closing the ticket because other things are incoming.

Itms commented

2016-12-27 09:49:42 +00:00

See ac190ecea2

Small updates to build scripts, refs #4419.

Tweak the coverage script.
Update the clean-workspaces script to be able to avoid rebuilding libraries.

Differential Revision: https://code.wildfiregames.com/D2

See ac190ecea2a9a95adde965f62673956ecb5a88c9 ``` Small updates to build scripts, refs #4419. Tweak the coverage script. Update the clean-workspaces script to be able to avoid rebuilding libraries. Differential Revision: https://code.wildfiregames.com/D2 ```

Itms commented

2017-01-30 12:47:10 +00:00

See 70c8a09fe4

Remove all occurrences of for each in JS scripts.
This will allow us to use some linters that would otherwise crash on this non-standard SpiderMonkey feature. Refs #4419.

Special thanks to elexis for thoroughly checking and testing all the changes!
Reviewed By: leper, elexis

Differential Revision: https://code.wildfiregames.com/D40

See 70c8a09fe4680d2664249203007599fa262dbbed ``` Remove all occurrences of for each in JS scripts. This will allow us to use some linters that would otherwise crash on this non-standard SpiderMonkey feature. Refs #4419. Special thanks to elexis for thoroughly checking and testing all the changes! Reviewed By: leper, elexis Differential Revision: https://code.wildfiregames.com/D40 ```

Itms commented

2017-06-11 10:38:41 +00:00

This is not bound to an Alpha version, and I'm not going to commit updates during the A22 Feature Freeze.

Itms modified the milestone from Alpha 22 to Work In Progress

2017-06-11 10:38:41 +00:00

Itms commented

2017-06-11 10:38:41 +00:00

Patch removed.

**Patch removed.**

Itms commented

2017-10-28 15:54:46 +00:00

See d599ea5922

Add our script for building patches with Jenkins to version control.

Refs #4419.
Reviewed By: leper, elexis
Differential Revision: https://code.wildfiregames.com/D18

See d599ea59225e1b32c78afcb04bea6dce823c2c71 ``` Add our script for building patches with Jenkins to version control. Refs #4419. Reviewed By: leper, elexis Differential Revision: https://code.wildfiregames.com/D18 ```

Itms commented

2019-12-16 21:52:50 +00:00

See 0dc35cc542

Update the Jenkins scripts to match the current state, which uses Jenkins pipelines, Docker for reproductible build environments, and ZFS for space efficiency and robust incremental patching. refs #4419, refs #4312.

Reviewed By: Angen
Differential Revision: https://code.wildfiregames.com/D1910

See 0dc35cc54200297300f0c1ce7a88a8e4f30e0ff0 ``` Update the Jenkins scripts to match the current state, which uses Jenkins pipelines, Docker for reproductible build environments, and ZFS for space efficiency and robust incremental patching. refs #4419, refs #4312. Reviewed By: Angen Differential Revision: https://code.wildfiregames.com/D1910 ```

Stan commented

2022-09-06 09:14:44 +00:00

Backlogging due to lack of progress and the user retiring.

Stan modified the milestone from Work In Progress to Backlog

2022-09-06 09:14:44 +00:00

Itms was unassigned by Stan

2022-09-06 09:14:44 +00:00

Sign in to join this conversation.